Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set preview attributes with an option #155

Closed
bohni opened this issue Jan 2, 2019 · 4 comments

Comments

@bohni
Copy link

commented Jan 2, 2019

It would be great to set the URL of the plantuml server as a setting, not as variable in the asciidoc document itself.

@anoff

This comment has been minimized.

Copy link

commented Mar 12, 2019

Any ideas where/how to fix this? Would be happy to contribute, but have no experience with vscode plugins 😞

@MatteoCampinoti94

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

We could add a settings option to add attributes to the preview. We could have an option like this:

"asciidoc.preview.attributes": {
  "attribute1": "value1",
  "attribute2": "value2",
  "attribute3": "value3"
}
@MatteoCampinoti94

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

It would require you to always add the value field, empty if necessary, but otherwise it would support unsetting and not-overriding (attribute@) attributes.

@MatteoCampinoti94 MatteoCampinoti94 changed the title plantuml-server-url as setting Set preview attributes with an option Apr 28, 2019

@MatteoCampinoti94

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Closed with release 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.