Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json and package-lock.json are not in sync after prepare branch for development [no ci] #862

Closed
ViToni opened this issue Mar 23, 2024 · 2 comments
Labels

Comments

@ViToni
Copy link
Contributor

ViToni commented Mar 23, 2024

Please provide details about:

  • What you're trying to do: npm install
  • What happened: package-lock.json gets modified because it has a different project version than package.json
  • What you expected to happen: Whenever the project version gets bumped the project versions should match between package.json and package-lock.json. Otherwise the first PR after the version bump must contain the "unrelated fix" for package-lock.json.

There are commits only changing package.json:

@ViToni ViToni changed the title pacakge.json and package-lock.json are not in sync after prepare branch for development [no ci] package.json and package-lock.json are not in sync after prepare branch for development [no ci] Mar 23, 2024
@ggrossetie
Copy link
Member

ggrossetie commented Mar 24, 2024

We are using npm pkg set version but it does not update the package-lock.json:

npm pkg set version="$(npx semver -i patch $RELEASE_VERSION_WITHOUT_PRERELEASE)-dev"
git commit -a -m 'prepare branch for development [no ci]'

@ggrossetie
Copy link
Member

Maybe we should use npm version with --no-git-tag-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants