update nokogiri to 1.8.0 for ruby >= 2.1 #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltador
force-pushed
the
nokogiri-update
branch
from
e6dd0e3
to
d9f7230
Compare
fixes dependencies installation on Windows with ruby >= 2.4
mojavelinux
force-pushed
the
nokogiri-update
branch
from
d9f7230
to
20c3b6b
Compare
mojavelinux
changed the title
|
I updated it to apply to Ruby 2.1 as well since that is still compatible. |
|
Thanks! |
|
x64-mingw32 and x86-mingw32 versions require Ruby 2.2 while general version requires 2.1. That's why I put the higher denominator of 2.2 version. |
|
that's kind of insane. hmm, I'd rather make an exception for that one case then. |
|
see if that works |
|
It works, thanks! |
mojavelinux
pushed a commit
that referenced
this pull request
Mar 16, 2018
fixes dependencies installation on Windows with ruby >= 2.4
mojavelinux
pushed a commit
that referenced
this pull request
Mar 16, 2018
fixes dependencies installation on Windows with ruby >= 2.4
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dependencies installation on Windows with ruby >= 2.4.