Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quotes substitution within verse blocks #949

Closed
cristoper opened this issue May 14, 2014 · 3 comments
Closed

quotes substitution within verse blocks #949

cristoper opened this issue May 14, 2014 · 3 comments
Assignees
Milestone

Comments

@cristoper
Copy link

The user manual says, "The quotes substitution occurs on formatted text within title, paragraph, example, quote, sidebar, and verse blocks." So I'd expect the strong quotes in this asciidoc snippet to be substituted to <strong> tags:

[verse]
And when I was ten *you murdered law with courtroom politics,*
And you learned to make a lie sound just like truth;
But I know you better now and I don't fall for all your tricks,
And you've lost the one advantage of my youth.

However, running "asciidoctor -b html5 -s" on the above produces this output (version 0.1.4):

<div class="verseblock">
<pre class="content">And when I was ten *you murdered law with courtroom politics,*
And you learned to make a lie sound just like truth;
But I know you better now and I don't fall for all your tricks,
And you've lost the one advantage of my youth.</pre>

(Note the * quotes have not been converted to STRONG tags.)

Setting [subs="normal"] causes the quoted text to be expanded properly, but I'd rather have quotes substituted by default than have to modify all of my verse blocks

Running the python asciidoc on the same input results in the expected output:

<div class="verseblock">
<pre class="content">And when I was ten <strong>you murdered law with courtroom politics,</strong>
And you learned to make a lie sound just like truth;
But I know you better now and I don&#8217;t fall for all your tricks,
And you&#8217;ve lost the one advantage of my youth.</pre>
<div class="attribution">
</div></div>
@mojavelinux
Copy link
Member

This problem is already fixed as of 1.5.0.preview.6. I'll give you an opportunity to try this with the latest Asciidoctor release. I'll close the issue once you confirm it's fixed for your use case.

To get the latest Asciidoctor release, run:

$ gem install asciidoctor --pre

@mojavelinux mojavelinux added this to the v1.5.0 milestone May 16, 2014
@mojavelinux mojavelinux self-assigned this May 16, 2014
@cristoper
Copy link
Author

Thank you, mojavelinux. I can confirm that this works as expected with 1.5.0.preview.6, so you may close this issue. In the future I'll be more diligent about testing with the latest gem/git version before opening spurious issues!

@mojavelinux
Copy link
Member

👍

Don't be too hard on yourself about the duplicate. This is mostly on us for
letting the 1.5.0 release linger so much. In the future we'll be releasing
more rapidly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants