Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering a PDF emits warning with 1.5.8 #707

Closed
robertpanzer opened this issue Oct 29, 2018 · 4 comments
Closed

Rendering a PDF emits warning with 1.5.8 #707

robertpanzer opened this issue Oct 29, 2018 · 4 comments

Comments

@robertpanzer
Copy link
Member

When rendering a PDF with the latest 1.5.8 I get a warning:

Okt 29, 2018 6:02:24 PM <script> (root)
WARNUNG: gem 'concurrent-ruby' is not installed. This gem is recommended when registering custom converters.

Apparently I forgot to add this gem.

@mojavelinux Is this critical? Should I prepare a 1.5.8.1 release?

@mojavelinux
Copy link
Member

I forgot to give you a heads up about this. Asciidoctor 1.5.8 no longer uses thread_safe. That gem has been deprecated. It now uses concurrent-ruby. It provides the same functionality, but does not offer a compatible API. For details, see asciidoctor/asciidoctor#2822.

@robertpanzer
Copy link
Member Author

So do you think we need a new release?

I guess we will have to keep thread_safe in the asciidoctorj.jar because asciidoctorj-pdf relies on it being available.

@mojavelinux
Copy link
Member

So do you think we need a new release?

Yes, I think it's worth it.

I guess we will have to keep thread_safe in the asciidoctorj.jar because asciidoctorj-pdf relies on it being available.

Correct. Both are currently needed.

@robertpanzer
Copy link
Member Author

Fixed with 1.5.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants