Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

URL support not working on Mac OS X #7

Closed
bwklein opened this issue May 15, 2016 · 4 comments
Closed

URL support not working on Mac OS X #7

bwklein opened this issue May 15, 2016 · 4 comments
Labels
Milestone

Comments

@bwklein
Copy link
Contributor

bwklein commented May 15, 2016

Report from @chuckf originally on https://github.com/bwklein/asciidoc-image-helper/issues/20

Using Atom 1.7.3 and asciidoc-image-helper 0.9.2, when I paste a path to an image file that path pastes in and does not convert to an image:: link as expected.

The test path I have used is:

/Users/chuckf/Downloads/splunk.png
/Users/chuckf/Downloads/splunk.jpg

Expected result is

image::splunk.png
image::splunk.jpg

Actual result:

/Users/chuckf/Downloads/splunk.png
/Users/chuckf/Downloads/splunk.jpg

NOTE: When pasting similar paths on a Fedora box, same versions of the software, the URLs are converted to image:: links as expected.

I don't get a success or error message popup.

I opened the console window with cmd-alt-i (for future reference) and did not see any errors occur when pasting in the link.

I typed the paths into a text editor, HTML page, and ran the command ls /Users/chuckf/Downloads/splunk.png into the native terminal and iterm2. I then selected the text and copied using cmd-c and pasted into Atom using cmd-v.

@bwklein bwklein added the bug label May 15, 2016
@nicorikken
Copy link

Just tried it out and can confirm the issue. This functionality did work previously. Small caveat: I just restructured my package install, which might have been messing things up. (but of course no way to verify 😉 )

@bwklein
Copy link
Contributor Author

bwklein commented May 25, 2016

I think that it might be how we are handling the string in Line 88.
https://github.com/asciidoctor/atom-asciidoc-image-helper/blob/master/lib/main.coffee#L88

@nicorikken
Copy link

Then this commit would have messed things up? c1e4fe7

@bwklein
Copy link
Contributor Author

bwklein commented May 25, 2016

Should be fixed in #13

@ldez ldez closed this as completed in 8b6fda4 May 25, 2016
@ldez ldez added this to the 0.9.x milestone May 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants