-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: Remove english shell dependency in manage.sh script #1479
Conversation
760e14a
to
cd38624
Compare
rebased on master |
cd38624
to
7b9c8f7
Compare
Rebased on master |
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
+ Coverage 72.33% 72.38% +0.04%
==========================================
Files 108 108
Lines 6210 6210
Branches 1072 1072
==========================================
+ Hits 4492 4495 +3
+ Misses 1441 1438 -3
Partials 277 277
Continue to review full report at Codecov.
|
Hi @milouse, please apologize the late response .. thanks for pointing out this bug! A more simpler solution might be:
what do you think? |
Effectivelly, it can be a more simple solution. I discover only recently the locale switch trick, that's why I didn't choose it initially. Feel free to use it instead! |
This reverts commit 7b9c8f7.
see searx#1479 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! .. and sorry for the delay :)
The current
manage.sh
script checks its internal methods using:A problem occurs when your shell locale is not english. Mine is french for example and
command -V update_packages
will return:fonction
being different thanfunction
, the script does not work at all.This pull requests replace the
command
by ased
one, which expect than the internal method will all use the same syntax. That way, method check is now language independant. However, the sed check is very naive for now and would need improvement the day more methods (or "private" methods) will be added to the script.