Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write multiple hash algorithms in one create pass broken? #112

Closed
Scott-Larsen opened this issue Feb 6, 2022 · 3 comments
Closed

Write multiple hash algorithms in one create pass broken? #112

Scott-Larsen opened this issue Feb 6, 2022 · 3 comments

Comments

@Scott-Larsen
Copy link

In an e-mail to Jon Waggoner asking whether it's possible to output multiple hash algorithms in a single .mhl file he seems to indicate that it's possible but may be broken. If it is possible, especially if it's working, it would be great to have an example in the Readme of how to properly call multiple algorithms. I tried to dig through the code as a junior developer, unfamiliar with the project but the multiple=False, on line 50 of commands.py had me thinking it wasn't possible. Thanks for all your work on this, everyone.

@jwaggs
Copy link
Collaborator

jwaggs commented Feb 7, 2022

@Scott-Larsen thanks for opening the issue. You are correct - multiple has been disabled via line 50 of commands.py.

We have a meeting on Wednesday at 5:30pm PDT - I'll bring this up during the meeting. I think this is one of those features that got sidelined til "later" - and that time has finally arrived. Would be good to get this fixed.

I looked under the hood a bit and there are several sections of code that would need refactoring to support this.

If you end up digging any deeper, feel free to open a pull request. I likely won't be able to take a stab at fixing this for a few weeks considering my current workload.

@ptrpfn
Copy link
Collaborator

ptrpfn commented Feb 15, 2022

FYI: @mthudgins is working on this already in branch dev/multiple-checksum-output.

@ptrpfn
Copy link
Collaborator

ptrpfn commented Mar 15, 2022

Is resolved and merged.

@ptrpfn ptrpfn closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants