Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Supabase support #123

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

MonsterDeveloper
Copy link
Contributor

@MonsterDeveloper MonsterDeveloper commented Mar 8, 2024

Hey!

I wanted to create this PR for a while now, however Supabase Transformations didn't have free access, so I had to contact the support to request it for this case with Unpic. Yet I still haven't heard anything from them.

CleanShot 2024-03-08 at 15 50 50@2x

I just saw another similar PR by @danestves, but I didn't now about his work when I was creating my implementation. Anyway, not to waste the written code I'll add this PR, but please feel free to merge either one.

I'll publish it as a draft for now until I get the access to the Transformations from Supabase

@MonsterDeveloper MonsterDeveloper changed the title Add Supabase support feat: add Supabase support Mar 8, 2024
@ascorbic
Copy link
Owner

ascorbic commented Mar 8, 2024

Thanks for the contribution. What I'm going to do is hit up my contacts at Supabase and see if they can sort us out some sample URLs to use. I think that's better than relying on anyone's own account.

@MonsterDeveloper
Copy link
Contributor Author

@ascorbic I got a reply from Supabase saying that they've enabled image transformations for my example, so the demo with my link is working now. Although it'd be nice if you could come up with a project-independent or at least user-independent link.

@MonsterDeveloper MonsterDeveloper marked this pull request as ready for review March 12, 2024 09:01
@ascorbic
Copy link
Owner

Great. I've pinged @inian who might be able to sort us out with some official demo URLs

@ascorbic ascorbic force-pushed the supabase branch 3 times, most recently from 37e7b08 to c3967ff Compare March 12, 2024 09:48
@ascorbic ascorbic merged commit 0aa185a into ascorbic:main Mar 12, 2024
6 checks passed
@mixie-bot mixie-bot bot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants