Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rack v1: invalid tags in plugin.json #41

Closed
cschol opened this issue Jun 19, 2019 · 2 comments
Closed

Rack v1: invalid tags in plugin.json #41

cschol opened this issue Jun 19, 2019 · 2 comments

Comments

@cschol
Copy link

cschol commented Jun 19, 2019

The manifest validator found invalid tags in the plugin.json:

Validating AS
TriLFO: invalid tags: Triple
TriggersMKI: invalid tags: Trigger
TriggersMKII: invalid tags: Trigger
TriggersMKIII: invalid tags: Trigger
SuperDriveFx: invalid tags: Overdrive
TremoloFx: invalid tags: Tremolo
TremoloStereoFx: invalid tags: Tremolo, Stereo

The list of valid tags is defined here: https://github.com/VCVRack/Rack/blob/v1/src/plugin.cpp#L534
@cschol cschol mentioned this issue Jun 19, 2019
Closed
@AScustomWorks
Copy link
Owner

Sorry, forgot to remove those tags, fixed now: 8ece883

Any chance to add "Overdrive" and "Tremolo" to the valid tags list?

@cschol
Copy link
Author

cschol commented Jun 19, 2019

Thanks. Put in a feature request with Andrew in the Rack repo.

@cschol cschol closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cschol @AScustomWorks