-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor code smells in static code analysis #1676
Comments
Do these cause any issue for the benchmarking? Looking over the "smells" I see:
|
There weren't any issues with benchmarking; it had a bunch of even more minor (minor-er?) suggestions that I ignored, but in this case it said |
If these aren't an issue for the benchmarking I'm inclined to leave the code as-is. The As far as I'm aware, |
ok, sounds good to me then! I'll mark the issues as "ignore" in sonarqube |
when running SonarQube scanning on
asdf
in thebench
repository, it found some minor code smells:duplicates in regex character class
https://plsonarqube.stsci.edu/project/issues?tags=regex&branch=sonarscan&id=spacetelescope-bench&open=AYttO5qgrmNdxaPHqW54
asdf/asdf/_jsonschema/tests/_suite.py
Line 176 in ecb4d4f
variable name shadows builtin
https://plsonarqube.stsci.edu/project/issues?tags=pitfall&branch=sonarscan&id=spacetelescope-bench
asdf/asdf/_jsonschema/_legacy_validators.py
Line 138 in ecb4d4f
asdf/asdf/_jsonschema/_legacy_validators.py
Line 154 in ecb4d4f
asdf/asdf/_jsonschema/tests/test_validators.py
Line 332 in ecb4d4f
asdf/asdf/_tests/test_yaml.py
Line 284 in ecb4d4f
asdf/asdf/commands/edit.py
Line 101 in ecb4d4f
asdf/asdf/compression.py
Line 265 in ecb4d4f
asdf/asdf/generic_io.py
Line 888 in ecb4d4f
asdf/asdf/generic_io.py
Line 897 in ecb4d4f
asdf/asdf/generic_io.py
Line 902 in ecb4d4f
The text was updated successfully, but these errors were encountered: