Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic_version.SpecItem is deprecated #702

Closed
nden opened this issue Aug 29, 2019 · 5 comments · Fixed by #715
Closed

semantic_version.SpecItem is deprecated #702

nden opened this issue Aug 29, 2019 · 5 comments · Fixed by #715

Comments

@nden
Copy link
Contributor

nden commented Aug 29, 2019

semantic_version.Specitem is deprecated in v 2.8 and will be removed in v 3.0. Astropy raises the DeprecationWarning as an error. To work around this semantic_version was limited in setup.py to <=2.6 but the code in asdf.versioning.py needs a replacement of the deprecated object.

@pllim
Copy link
Contributor

pllim commented Sep 30, 2019

Why not get rid of semantic_version and use setuptools_scm?

@jdavies-st
Copy link
Contributor

asdf already uses setuptools_scm. I think this versioning has to do with schema versioning in the ASDF standard.

@pllim
Copy link
Contributor

pllim commented Sep 30, 2019

You mean this?

https://github.com/spacetelescope/asdf/blob/dcccfd0652db9266e74a53abcb83c37e8381304f/asdf/versioning.py#L161-L167

Hmm... That list doesn't seem to correspond to asdf-standard releases. Maybe a minversion would suffice? 🤷‍♀️

@pllim
Copy link
Contributor

pllim commented Sep 30, 2019

Also, maybe you don't need a third-party package to do version string parsing. Then you free yourselves of this issue completely, now and forever.

@nden
Copy link
Contributor Author

nden commented Nov 13, 2019

As mentioned in this comment look into using SimpleSpec or BaseSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants