Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-build: definition not found: 18.16.0 #345

Closed
hrishikesh-k opened this issue Apr 16, 2023 · 12 comments
Closed

node-build: definition not found: 18.16.0 #345

hrishikesh-k opened this issue Apr 16, 2023 · 12 comments

Comments

@hrishikesh-k
Copy link

Looks similar to: #283 and #297, except for a different version now.

asdf install nodejs lts still installs 18.15.0.

Why does this happen?

@ksmithut
Copy link

It looks like the list that node-build pulls from is out of date. If you run asdf list all nodejs, it's also not showing the latest version, 19.9.0

@mrienstra
Copy link

Upstream issue: nodenv/node-build#806
PR adding 18.16.0 & 19.9.0, blocked by CI issue: nodenv/node-build#804
PR containing fix for CI issue: nodenv/node-build#805

@mrienstra
Copy link

Both nodenv/node-build#805 & nodenv/node-build#804 were merged, huzzah! I think this issue can be closed now, tested locally:

asdf nodejs update-nodebuild
asdf list-all nodejs | grep -E '^(18\.16\.0|19\.9\.0)$'

Output:

18.16.0
19.9.0

@hrishikesh-k
Copy link
Author

Can confirm it works! Thanks for the quick fix to all involved!

@perlun
Copy link

perlun commented Jun 27, 2023

Hmm, I'm still getting issues when trying to install Node.js LTS via asdf. 🤔

Trying to update node-build... ok
node-build: definition not found: 18

asdf and the plugins should be updated to the latest versions, but please let me know if I may have messed something up:

$ asdf --version
v0.12.0-816195d

$ asdf plugin list --urls
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git
ruby                         https://github.com/asdf-vm/asdf-ruby.git

@augustobmoura
Copy link
Member

Hmm, I'm still getting issues when trying to install Node.js LTS via asdf. thinking

Update your asdf-nodejs plugin and check the new documentation on how to setup dynamic versions on your legacy version file

@frozencap
Copy link

getting the same issue

@holtalanm
Copy link

same issue here.

running asdf nodejs install lts gives node-build: definition not found: 18

@adamski
Copy link

adamski commented Aug 9, 2023

Same here. I can see all versions of 18 with asdf list all nodejs but I get the same error message as above

@bed-sb
Copy link

bed-sb commented Sep 6, 2023

Same issue here

@bdarfler
Copy link

bdarfler commented Sep 6, 2023

You need to set ASDF_NODEJS_LEGACY_FILE_DYNAMIC_STRATEGY per https://github.com/asdf-vm/asdf-nodejs#partial-and-codename-versions

@augustobmoura
Copy link
Member

augustobmoura commented Sep 6, 2023

I'm locking this thread as people are not reading the documentation for it and just piling up comments. If you are having messages like node-build: definition not found: 18, node-build: definition not found: lts or similar, please check:

  • That your asdf installation and asdf-nodejs plugin are updated to the latest version, do that by running asdf update && asdf plugin update nodejs
  • Check if you have a partial version on your .tool-versions file, we do not support partial/codename versions on the .tool-versions file, we value reproducibility and having dynamic ranges on the file is not on our best interest. So either
    • Pin the version on .tool-versions or on your command to a full version number (E.g.: 18.17.1). We provide a sub-command that can help with that
    • Use the partial/codename version with an legacy version file (either .nvmrc or .node-version), and choose between a dynamic version resolution strategy

If your problem is not related to any of these fixes that I mentioned above, please open a new issue for it

@asdf-vm asdf-vm locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants