fix: enforce consistent shell redirection format

[hyperupcall]

Summary

Make redirections more consistent

[jthegedus]

I have no objection to this change. I would like to get @Stratus3D opinion.

[Stratus3D]

I could go either way on this - I actually wasn't familiar with the &> shorthand (maybe that's obvious looking at the codebase 😛 ), but it does make the code cleaner.

@hyperupcall &> isn't POSIX is it? I assume we can only enforce this on Bash files.

[jthegedus]

@hyperupcall &> isn't POSIX is it? I assume we can only enforce this on Bash files.

I guess if it isn't, we would just want to ensure checkstyle.py only asserts/fixes this rule for .bash files.

[hyperupcall]

Yeah it's not POSIX, so the rule would have conflicted with ShellCheck in .sh files, good catch.

I modified the CheckStyle so this new rule only applies to our POSIX shell Bash files 😄

[jthegedus]

so this new rule only applies to our POSIX shell files

@hyperupcall Do you mean non-POSIX? We want to apply this to .bash and NOT .sh, right?

Sorry, I am getting confused.

[hyperupcall]

@jthegedus My apologies, that was me - fixed

[Stratus3D]

@jthegedus you can merge whenever you are ready.