Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename internal plugin repository functions #1537

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Apr 12, 2023

Summary

Use plugin in the function name for functions that reference the plugin repository.

I was making these changes in #1437 and thought they could be pulled out separately for easier review.

Other Information

I am torn about the impact on semver here (fix or chore). On the one hand, code is being changed that users would execute, so this code should be released under a new version, a fix. Whereas the external API is not being changed so it could probably be a chore with the change going out with the next release (any subsequent fix or feat). 馃し

Historically I have been encouraging any change to code that effects the user to go under fix, even if just code style changes, so will stick to that here. But this is certainly open to discussion should anyone care.

@jthegedus jthegedus requested a review from a team as a code owner April 12, 2023 02:55
@jthegedus jthegedus merged commit 5367f1f into master Apr 12, 2023
@jthegedus jthegedus deleted the rename-plugin-repo-specific-functions branch April 12, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant