Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid bits of noise in frequency calculation #36

Closed
asearfos opened this issue Jun 15, 2019 · 1 comment
Closed

avoid bits of noise in frequency calculation #36

asearfos opened this issue Jun 15, 2019 · 1 comment
Labels
bug

Comments

@asearfos
Copy link
Owner

This problem come from how we are defining a syllable. Since a syllable is any signal between an onset and offset (with no frequency bounds) then any noise above or below what the eye would call the syllable is being counted when max and min are being measured.

Only idea to improve this as of right now is to use the note threshold and remove anything below it before conducting syllable calculations (including similarity check?).
@asearfos asearfos added the bug label Jun 15, 2019
asearfos referenced this issue Aug 19, 2019
@asearfos
Merge pull request #43 from asearfos/exclude_noise_smaller_then_notes…
61d6a3f 
…_from_analysis

Exclude noise smaller then notes from analysis
@asearfos
Copy link
Owner Author

Fixed with merge of #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asearfos