Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ms, not sec, for elapsed time #10

Closed
rwdaigle opened this issue May 24, 2012 · 3 comments
Closed

Use ms, not sec, for elapsed time #10

rwdaigle opened this issue May 24, 2012 · 3 comments

Comments

@rwdaigle
Copy link

The standard, as far as I can tell amongst the libraries I use, is to print elapsed/execution time in ms (to 2 decimal places), not seconds as Scrolls does. I'm advocating to see output such as:

action=email-import at=finish elapsed=31.21

Instead of the current:

action=email-import at=finish elapsed=0.031

If this is agreeable then I'll submit a pull request.

@asenchi
Copy link
Owner

asenchi commented May 31, 2012

@rwdaigle Hmm, yeah i agree. I wonder how if a change to this currently would clobber existing metrics?

I am working on a cleanup of scrolls and fixing a lot of issues, I'll add this to that. I am hesitant to change this in the current releases.

@rwdaigle
Copy link
Author

Yeah, agree on breaking existing metrics. Few thoughts:

  • Make the unit of time configurable and default to secs.
  • Print the units in the output. E.g. 31.21s and 0.031ms

@asenchi
Copy link
Owner

asenchi commented Jun 19, 2012

This is fixed in the v2 branch, I'll be merging that sometime this week.

@asenchi asenchi closed this as completed Jun 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants