Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing faiss::FaissException in the compile procedure #93

Open
yfyang86 opened this issue Aug 16, 2023 · 1 comment
Open

[BUG] Missing faiss::FaissException in the compile procedure #93

yfyang86 opened this issue Aug 16, 2023 · 1 comment

Comments

@yfyang86
Copy link

[BUG] Missing faiss::FaissException in the compile procedure

  • FAISS Version: Current master as 2023-08-16 faiss
  • sqlite-vss Version: Current master

Behavior:

Error message

no type named 'FaissException' in namespace 'faiss'

Fix, add the <faiss/impl/FaissException.h> file to sqlite-vss.cpp:

...
#include <random>

#include <faiss/impl/FaissException.h>
#include <faiss/IndexFlat.h>
#include <faiss/IndexIVFPQ.h>
#include <faiss/impl/AuxIndexStructures.h>
...
@asg017
Copy link
Owner

asg017 commented Aug 16, 2023

If you checkout the submodules in the sqlite-vss repo, it points to the facebookresearch/faiss@868e17f , which is pretty old. We can bump this to something newer (at least v1.7.4, Apr 19th ), where we can update the #includes to fix errors like this.

But if you're compiling sqlite-vss yourself, I recommend checking out the submodules in that repo, since we haven't tested on newer version of Faiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants