Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilng with latest 1.17 RC throws warnings that cause failure to compile when compiling with warnings as errors #175

Closed
allenwyma opened this issue Jun 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@allenwyma
Copy link

Describe the bug
Elixir 1.17 rc 1 is throwing warnings upon compiliation. When I compile with warnings as errors, I get an error.

To Reproduce
Use 1.1.1 ash_graphql, setup the project, and use Elixir 1.17-rc.1 with otp 27 and use mix compile

Expected behavior
Compile without throwing an error.

** Runtime

  • Elixir version 1.17.0-rc.1
  • Erlang version 27.0
  • OS mac OS
  • Ash version 3.0.10
  • any related extension versions

Additional context

warning: using map.field notation (without parentheses) to invoke function Ash.Query.Operator.IsNil.predicate?() is deprecated, you must add parentheses instead: remote.function()
  (ash_graphql 1.1.1) lib/resource/resource.ex:2267: anonymous fn/1 in AshGraphql.Resource.filter_type/3
  (elixir 1.17.0-rc.1) lib/enum.ex:4301: Enum.filter_list/2
  (ash_graphql 1.1.1) lib/resource/resource.ex:2267: AshGraphql.Resource.filter_type/3
  (elixir 1.17.0-rc.1) lib/enum.ex:4353: Enum.flat_map_list/2
  (ash_graphql 1.1.1) lib/resource/resource.ex:2217: AshGraphql.Resource.filter_field_types/2

I saw this was fixed in absinthe: absinthe-graphql/absinthe#1318

@allenwyma allenwyma added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant