You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been wondering about the backpressure strategy you have set for the flowable on database. Right now it's set to buffer, which will maintain a buffer of ALL events. I'm not sure that this is the right approach. If the purpose is to wrap firebase with rx, there's rarely a good reason to present inaccurate snapshots to any consumer. I think you should be using the LATEST backpressure strategy. In LATEST, if n writes occur before n-1 writes are read by the subscriber, the latest value will be overwritten on the unread write. This seems to be exactly what firebase does in an non-rx flow.
What do you think?
The text was updated successfully, but these errors were encountered:
I had been thinking more on the use case of addChildEventListener where snapshots wouldn't necessarily be inaccurate and the responsibility comes to the consumer to decide on the relevancy.
I understand your point, but I prefer this approach as it doesn't risk any data not being "lost", perhaps it could be made clearer to the user that they must handle potentially outdated snapshots, or allow them to specify their own backpressure strategy.
I've been wondering about the backpressure strategy you have set for the flowable on database. Right now it's set to buffer, which will maintain a buffer of ALL events. I'm not sure that this is the right approach. If the purpose is to wrap firebase with rx, there's rarely a good reason to present inaccurate snapshots to any consumer. I think you should be using the
LATEST
backpressure strategy. In LATEST, if n writes occur before n-1 writes are read by the subscriber, the latest value will be overwritten on the unread write. This seems to be exactly what firebase does in an non-rx flow.What do you think?
The text was updated successfully, but these errors were encountered: