Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fan values don't work well with Homekit #4

Open
electroflame opened this issue Feb 17, 2024 · 3 comments
Open

Fan values don't work well with Homekit #4

electroflame opened this issue Feb 17, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@electroflame
Copy link

Hi there -- thanks for the integration!

This works great overall. However, Homekit's fan control seems to trigger the min/max cap, so rather than a full range of 0-100, you can only set the fan speed in pre-defined steps (it seems like about 4 steps). This is kind of confusing, as you can drag the fan slider and Homekit thinks the value is set, but the Bedjet doesn't actually respond. If you close/reopen the Home app the slider will update with what the Bedjet's actually set to.

Does the plugin just automatically try to cap the value to the nearest pre-defined step?

@asheliahut
Copy link
Owner

To tell you the truth @electroflame this is a fork that I have been just making work on basically a maintenance purposes and made it a little more user friendly to setup/manage. I don't know how the original code works that well or how the code works with the BedJet. I am open to discussions on it and time to dig in more to make it better, but honestly I never even looked at the original code that deep to know what it does for setting the values.

@electroflame
Copy link
Author

@asheliahut Haha, fair enough. I'm not that familiar with Python otherwise I would've taken more than a cursory look.

Basically it seems like the fan values are being clamped by the presets (i.e. Low, Medium, High), even when trying to set a value directly via Homekit. Basically you can't set values in increments of 5% like you can on the remote, as it jumps to values roughly around 33%, 66%, 100%, etc.

It's interesting that the values reported by Homekit are also incorrect (i.e. 66% is reported when the remote is actually set to 75%) so I'm not sure what's going on there.

If I get a little more time I might try and take a closer look and see if I can figure out where things are going wrong -- that is if you don't get to it first.

@asheliahut
Copy link
Owner

Awesome! I will definitely look into this soon, but not 100% when yet.

@asheliahut asheliahut added enhancement New feature or request help wanted Extra attention is needed labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants