MoyaError does not include original URLRequest in all cases

[kamendo]

Hi,
My problem is that convertResponseToResult function does not always include the original URLRequest
So if the error is "No internet" we will get
MoyaError.underlying(error, nil), i.e. the error is missing the context of the original request which in my case is important

For example in my custom plugin, "didReceive(..." when I receive this error I get very limited information about the original request (I can only get some info from TargetType object) and I am unable to match it with willSend function

Please consider updating the source so that on all errors we have attached the original request

[ljluestc]

import Moya
import Combine

extension MoyaError {
    static func withRequest(_ request: URLRequest, error: Error) -> MoyaError {
        return .underlying(error, request)
    }
}

extension Publisher where Output == Response, Failure == MoyaError {
    func convertResponseToResult() -> AnyPublisher<Result<Response, MoyaError>, Never> {
        return map { .success($0) }
            .catch { error in
                guard let moyaError = error as? MoyaError else {
                    return Just(.failure(.underlying(error, nil))).eraseToAnyPublisher()
                }
                
                switch moyaError {
                case .underlying(let underlyingError, _):
                    if let urlRequest = underlyingError as? URLRequest {
                        return Just(.failure(MoyaError.withRequest(urlRequest, error: moyaError))).eraseToAnyPublisher()
                    } else {
                        return Just(.failure(moyaError)).eraseToAnyPublisher()
                    }
                default:
                    return Just(.failure(moyaError)).eraseToAnyPublisher()
                }
            }
            .eraseToAnyPublisher()
    }
}