Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide official Windows build #43

Closed
jrozner opened this issue Aug 20, 2020 · 2 comments · Fixed by #118
Closed

Provide official Windows build #43

jrozner opened this issue Aug 20, 2020 · 2 comments · Fixed by #118
Labels
enhancement New feature or request

Comments

@jrozner
Copy link
Member

jrozner commented Aug 20, 2020

The tool should theoretically work on Windows and has been built with cross platform support in mind. We should provide official builds and potentially some sort of installer, since that's how windows software is typically distributed. Likely also need to provide guidance on setting up the screenshot helper tools.

@jrozner jrozner added the enhancement New feature or request label Aug 20, 2020
@jrozner
Copy link
Member Author

jrozner commented Dec 18, 2020

It appears that windows does include some functionality to create screenshots but it doesn't seem to quite have a good enough solution built in. Windows 10 provides two different applications: SnippingTool.exe and "Snip and Sketch".

SnippingTool.exe seems to be deprecated or at least getting replaced by Snip and Sketch though it does not provide a timeline for when that will happen. It provides a flag /clip to allow you to select a region of the screen but does not appear to have a flag what will just grab the current screen. Running it without the /clip flag will cause the program to launch the gui to interact with. SnippingTool also does not provide the ability to specify where to save the screenshot to from the command line, it can only be saved from within the gui app. Using the /clip flag will simply save it to the clipboard. This is not ideal as we'd have to build custom logic from windows to handle pulling the bitmap from the clipboard and saving it and we still wouldn't have support for full screen captures.

Snip and Sketch appears to be the future of where Windows is going with included screenshot functionality. This tool is implemented as a UWP. It can be invoked via a protocol handler, as documented here but it doesn't appear to be an application that can be launched that way that we are in ashirt or have the ability to specify a location to write it the screenshot. It appears to copy the screenshot to the clipboard, but not save it, and not pass it back to the calling application. We maybe able to build a helper application that we can include on the windows side to invoke this tool and write out the screenshot but it's not clear if overwriting the clipboard would make us a bad citizen in the windows world of expected behavior.

Other options we can look into are identifying open source screenshotting apps, or imagmagick's import, and simply include a helper to handle the screen capture functionality. A user will always be able to supply their own option but given that this doesn't appear to be as common as in the linux world and there isn't an included option, like in macos, we may want to provide an option.

@jrozner jrozner mentioned this issue Feb 20, 2022
@jrozner
Copy link
Member Author

jrozner commented Feb 20, 2022

flameshot seems like it may be a good option to ship with the windows build. Not clear that it makes sense to ship with all platforms as macos has something that works out of the box and linux users may want to bring their own. Maybe providing as a default would be a good user experience though and provide the opportunity to switch to whatever the user wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant