Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to edit the description for non-submitted evidence #89

Closed
jrozner opened this issue Mar 24, 2021 · 1 comment · Fixed by #92
Closed

Make it possible to edit the description for non-submitted evidence #89

jrozner opened this issue Mar 24, 2021 · 1 comment · Fixed by #92
Labels
enhancement New feature or request triage Issue needs triage
Milestone

Comments

@jrozner
Copy link
Member

jrozner commented Mar 24, 2021

For evidence that hasn't yet been submitted it should be possible to edit the description and tags.

@jrozner jrozner added enhancement New feature or request triage Issue needs triage labels Mar 24, 2021
@JoelAtDeluxe
Copy link
Contributor

I created a PR to handle this scenario. The way it's intended to work is as follows:
Within the evidence manager, a user can click on a piece of evidence.

  • If it's submitted, then there's no change (technically, there's now a disabled edit button, with the tool tip that indicates you can only edit unsubmitted evidence)
  • If it's unsubmitted, then the user can click the edit button, and the description/tags fields become editable, as you would get when you first create the evidence. From here, you can click cancel, which should restore the state of the evidence, or save, which will update the evidence locally, but still not submit the evidence.
    Edit only works when exactly one item is selected. Any more or less and the button is grayed out with messaging indicating to select one item.

@jrozner jrozner added this to the 1.2.0 milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants