Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell isn't set during setup #33

Closed
jrozner opened this issue Mar 26, 2021 · 2 comments
Closed

Shell isn't set during setup #33

jrozner opened this issue Mar 26, 2021 · 2 comments
Labels
bug Something isn't working triage Issue needs triage

Comments

@jrozner
Copy link
Member

jrozner commented Mar 26, 2021

When the automatic setup runs the shell isn't set. This is present in the current release. Untested in master.

@jrozner jrozner added bug Something isn't working triage Issue needs triage labels Mar 26, 2021
@JoelAtDeluxe
Copy link
Contributor

This seems to be fixed in master. Here's what I tested

fresh start => always chooses $SHELL This seems to save properly in both version
update settings => this seems to omit saving, or saves an empty string. But, this seems to work on master.

@jrozner
Copy link
Member Author

jrozner commented Mar 26, 2021

Ah perfect. We should just cut a new release to get the fix then. I'll go ahead and close this.

@jrozner jrozner closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants