Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch 2.0 #490

Closed
wants to merge 13 commits into from
Closed

Pytorch 2.0 #490

wants to merge 13 commits into from

Conversation

johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Dec 20, 2022

New feature Pytorch 2.0 compile
Change pytorch-lightning(deprecated) to lightning
Pytorch 1.13.1 compatible with python 3.11
Only blocked tests torchvision but they are working to compatible with Python 3.11
Deleted Python 3.7 tests(very deprecated)

@ashleve
Copy link
Owner

ashleve commented Dec 26, 2022

Thank you for the PR @johnnynunez ! Could you consider splitting this into smaller, more atomic PRs?

Maybe a separate PR for renaming pytorch_lightning to lightning?

If I understand this correctly, pytorch 2.0 is currently in pre-release so I would prefer not to update the template until 2.0 is fully released.

"Deleted Python 3.7 tests(very deprecated)"

What do you mean by deprecated? In which library?

"Only blocked tests torchvision but they are working to compatible with Python 3.11"

Does it mean torchvision doesn't work currently with Python 3.11?

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Dec 26, 2022

@ashleve thanks to response.
1. Maybe a separate PR for renaming pytorch_lightning to lightning?
Yes, I could do it.
2. If I understand this correctly, pytorch 2.0 is currently in pre-release so I would prefer not to update the template until 2.0 is fully released.
Yess, but Pytorch 1.13.1 has .compile because TorchDynamo library now is in main repository.

3. What do you mean by deprecated? In which library?
I think that Python 3.8 is the currently most useful because for example google colab it's on this version right now. So, I thought to delete python 3.7 tests

4. Does it mean torchvision doesn't work currently with Python 3.11?
TorchVision depends on anaconda repositories and not python version binaries. So, anaconda is not still compatible with pytorch 3.11 but pytorch yes...

@ashleve
Copy link
Owner

ashleve commented Jan 1, 2023

@johnnynunez Sorry for delayed response, I was away for the past week.

  1. Sure, you can go for it.
    I would like to make the development more organized so from now on let's make all PRs into the dev branch and merge minor releases once in a while.

  2. Ok, then we can already do a separate PR for .compile() feature

  3. 3.7 is still officially supported by Python Foundation so I don't really see a reason to drop these tests unless some template dependency doesn't support it anymore.

  4. For now, let's just not extend the list of tests to 3.11 until the issue with conda is fixed

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Jan 18, 2023

@ashleve
Copy link
Owner

ashleve commented Feb 11, 2023

Deprecated python 3.7 with #523

@johnnynunez
Copy link
Contributor Author

@ashleve now is fixed in the last commit of master in lightning source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants