Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(case): project names are kebabs #64

Merged
merged 6 commits into from Jul 28, 2018

Conversation

ashleygwilliams
Copy link
Collaborator

@ashleygwilliams ashleygwilliams commented Jul 27, 2018

馃懢 do no merge 馃懢

fixes #63 and adds tests for:

  • when --name is passed to generate it should be kebab'd

@ashleygwilliams ashleygwilliams changed the title [WIP] test(case): project names are kebabs test(case): project names are kebabs Jul 27, 2018
Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Great to see this test, too :)


pub struct ProjectName {
pub kebab_case: String,
pub snake_case: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only store the raw input name (as a private field) and make these getters but it doesn't really matter right now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh i can do this now

@@ -0,0 +1,15 @@
use heck::{KebabCase, SnakeCase};

pub struct ProjectName {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to describe the pupose

Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once CI is green

@ashleygwilliams ashleygwilliams merged commit c18cba0 into master Jul 28, 2018
@ashleygwilliams ashleygwilliams deleted the the-mysterious-case-of-case branch July 28, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use heck instead of custom snake case function
2 participants