Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access-Control-Allow-Methods #19

Closed
Rulox opened this issue May 14, 2018 · 1 comment
Closed

Access-Control-Allow-Methods #19

Rulox opened this issue May 14, 2018 · 1 comment

Comments

@Rulox
Copy link

Rulox commented May 14, 2018

Hi,

I was going to use this on my sanic app, but I saw the CORS problem is partially solved. Nowadays, with the new standard in JS async requests (in this case, Fetch) , the browser uses an OPTIONS request to the endpoint in order to know some headers for the CORS. One is the one you're using already, but the other one is Access-Control-Allow-Methods

Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Methods

Are you planning to add support for this? (I'm not using it because I needed everything and I made my custom code, but I think it could be a nice addon to your package).

Thanks

@Rulox
Copy link
Author

Rulox commented May 14, 2018

Sorry my bad, I was looking the wrong code. It does support that.

@Rulox Rulox closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant