Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babelHelpers is undefined #9

Closed
jeroenptrs opened this issue May 9, 2018 · 0 comments
Closed

babelHelpers is undefined #9

jeroenptrs opened this issue May 9, 2018 · 0 comments

Comments

@jeroenptrs
Copy link
Contributor

jeroenptrs commented May 9, 2018 •
edited

What?

  • lib/index.js mentions babelHelpers, but it isn't defined in the component.
  • It breaks usage of the package.

How to fix?

  • Possibly a bad transpilation? Maybe just rerunning the transpilation might help.
  • Otherwise an upgrade to Babel 7 might help.

Workarounds for now

  • I'm just using the src/react-sane-contenteditable.js, copied it into my project and it seems to work!

I've added a PR #10 that fixes the babelHelpers issue, by externalizing the external-helpers package to a .babelrc in the example folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeroenptrs