Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encoding breaks state #1272

Open
im-aIex opened this issue Apr 26, 2023 · 3 comments
Open

URL encoding breaks state #1272

im-aIex opened this issue Apr 26, 2023 · 3 comments

Comments

@im-aIex
Copy link

im-aIex commented Apr 26, 2023

Some clients (looking at your Azure DevOps) will automatically re-encode Urls, resulting in the +s used in the state to be encoded as %2B. It would be nice if that were automatically re-decoded when loading the state from the Url.

@ashmind
Copy link
Owner

ashmind commented May 29, 2023

Thanks for reporting! It makes sense, but I am a bit on a fence with issues like these.

On one hand I would rather prefer the other application to fix unnecessary re-encoding.
On other hand they probably won't, and I do care about good user experience.

I'll consider it in the future, and make a decision later once I get to it again.

@TomasMalecek
Copy link

TomasMalecek commented Feb 9, 2024

Running into the issue quite often. Especially on pull requests, I often need to share a short demo in a comment. The comments use Markdown. Neither bare links nor URLs in Markdown links survive. :-(

In practice, I often share the link as a Markdown code block. DevOps does not fiddle with the contents of code blocks and my colleagues may copy-paste the URL.

@TomasMalecek
Copy link

I am not sure why the plus is even needed in the URL. Can it be replaced with another character? An underscore maybe? I believe fixing old links that never worked is not as important as enabling the sharing of new links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants