-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL encoding breaks state #1272
Comments
Thanks for reporting! It makes sense, but I am a bit on a fence with issues like these. On one hand I would rather prefer the other application to fix unnecessary re-encoding. I'll consider it in the future, and make a decision later once I get to it again. |
Running into the issue quite often. Especially on pull requests, I often need to share a short demo in a comment. The comments use Markdown. Neither bare links nor URLs in Markdown links survive. :-( In practice, I often share the link as a Markdown code block. DevOps does not fiddle with the contents of code blocks and my colleagues may copy-paste the URL. |
I am not sure why the plus is even needed in the URL. Can it be replaced with another character? An underscore maybe? I believe fixing old links that never worked is not as important as enabling the sharing of new links. |
Some clients (looking at your Azure DevOps) will automatically re-encode Urls, resulting in the
+
s used in the state to be encoded as%2B
. It would be nice if that were automatically re-decoded when loading the state from the Url.The text was updated successfully, but these errors were encountered: