Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect implementation of a password salt #1

Closed
ghost opened this issue Jun 23, 2014 · 2 comments
Closed

incorrect implementation of a password salt #1

ghost opened this issue Jun 23, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 23, 2014

check out this: https://crackstation.net/hashing-security.htm#salt

to see how to properly implement a salted password generator. right now you're using the "salt" as the list of characters that can be in the generated token.

@ashnur
Copy link
Owner

ashnur commented Jun 23, 2014

Hi, thanks for that link. You are right, and I am well aware of the misused terminology, it just happens that I am terrible at naming things. I couldn't come up with a better name for "the list of characters that can be in the generated token" :).

And to be clear, I would never use this lib for anything security related, it's just a simple way to have a random string in a convenient matter.

@ghost
Copy link
Author

ghost commented Sep 6, 2017

cool! thanks for replying 😄

@ghost ghost closed this as completed Sep 6, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant