Fix for PAM_USER env and more #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`args.rs` updated to: * Fix for bug #7 is implemented * for multichoice variables use `enum` instead of `String` * `Sarg` now has `Option` for variables that may have `None` values
`main.rs` updated to * `main()` only implements entry and exit code, the rest is moved to `run()`. * This change make it easier to implement Integration Test. * Refactor all the error message into a single function. * implemented `enum` instead of `String`
The code now accepts variables with `Option`
1. The common code for key calculation is refactored to separate functions and reused. 2. Variables now accept `Option` .
Wrapped the dataset with `Some()`
kiavash-at-work
commented
Aug 14, 2021
kiavash-at-work
commented
Aug 14, 2021
kiavash-at-work
commented
Aug 14, 2021
| // append the value from "PAM_USER" to the end of dataset, if it exists | ||
| // otherwise keep None | ||
| dataset = dataset | ||
| .map(|d| { |
There was a problem hiding this comment.
Like the comment on line 138, here is an example using map.
Remember that this code is closure and captures the environment variables.
kiavash-at-work
commented
Aug 14, 2021
kiavash-at-work
commented
Aug 14, 2021
kiavash-at-work
commented
Aug 14, 2021
to speed up the file hash is generated while waiting for user to enter password
replace `file` argument with `filehash` for parallel filehash generation (while user is entering password)
|
Well all this changes Look good to me, Thanks for this PR. I'll merge it right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
main()only for entry and exit. This helps in integration test implementation.Option<>support toSargsand related codes.