Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up and an example of unit test #3

Merged
merged 3 commits into from Jul 28, 2021
Merged

Code clean up and an example of unit test #3

merged 3 commits into from Jul 28, 2021

Conversation

kiavash-at-work
Copy link
Contributor

This PR contains 3 changes:

  1. Unit test for port_check() function in args.rs.
  2. The fix for port 0 to be rejected as an invalid port.
  3. Code clean up, merging matched arms and removing unnecessary brackets

@kiavash-at-work kiavash-at-work mentioned this pull request Jul 27, 2021
Closed
@kiavash-at-work
Copy link
Contributor Author

Interesting the the build failed for a reason not related to the PR 😕

error: failed to select a version for the requirement `aes-soft = "^0.4"`

@ashuio
Copy link
Owner

ashuio commented Jul 28, 2021

Interesting the the build failed for a reason not related to the PR confused

error: failed to select a version for the requirement `aes-soft = "^0.4"`

Looks like the aes-soft library used bu yubico-manager is officially merged with aes

will have to wait for an upstream fix

@ashuio ashuio merged commit 97f5754 into ashuio:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiavash-at-work @ashuio