Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] generate hash while waiting for user input #9

Closed
kiavash-at-work opened this issue Aug 13, 2021 · 6 comments
Closed

Comments

@kiavash-at-work
Copy link
Contributor

Currently, the hash generation happens after user entered password, however these can happen in parallel meaning while it is waiting for the user is to enter password, it spawn a task to generate the hash in background.

The time saved depends on the speed of user computer and its code execution.

@ashuio
Copy link
Owner

ashuio commented Aug 14, 2021

Yeah i think that's a good idea. I'll start looking into it.

@kiavash-at-work
Copy link
Contributor Author

Thanks. I also have some ideas that we can discuss later when you have more looked into it.

@kiavash-at-work
Copy link
Contributor Author

Over the weekend, I had some time to implement the parallel thread for filehash calculation.

a0ed0b4 and 9c8e30e

I tried to use a very straightforward method with adequate comments, but please let me know if you have any questions or comments.

@ashuio
Copy link
Owner

ashuio commented Aug 18, 2021

I am testing the PR and so far looks good.

@kiavash-at-work
Copy link
Contributor Author

Thank you for testing them. I realize until integration tests have not been developed, these type of changes will need manual testing.

@kiavash-at-work
Copy link
Contributor Author

Thank you for reviewing and merging the PR #12. I think we can close this case and if there are bugs in the implemented feature open a new case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants