Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system specific path #2

Closed
yashshah1 opened this issue Mar 11, 2021 · 1 comment
Closed

Remove system specific path #2

yashshah1 opened this issue Mar 11, 2021 · 1 comment

Comments

@yashshah1
Copy link

Not sure what functionality this adds, but ideally shouldn't exist in a code base that is distributed. Replace it with something more generic (since an importable library shouldn't need to mess with env vars)? If needed, possibly add a note in the docs for additional setup instructions?

sys.path.append('/home/ashutosh/parser-vis/')

@ashutoshbsathe
Copy link
Owner

Thanks a lot for noticing. That line should not be there. It was required initially when I would pass the .py file to manim. Now the library itself can initialize manim properly

a3256e8 fixes it
Thanks for noticing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants