Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces DurationPicker with TimePicker for wake up timer #306

Merged
merged 1 commit into from Sep 1, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #306 into master will increase coverage by 0.29%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   85.41%   85.71%   +0.29%     
==========================================
  Files          29       29              
  Lines        1440     1505      +65     
  Branches      172      176       +4     
==========================================
+ Hits         1230     1290      +60     
- Misses        112      115       +3     
- Partials       98      100       +2     
Flag Coverage Δ
#android 84.83% <71.42%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...shutoshgngwr/noice/fragment/WakeUpTimerFragment.kt 79.24% <71.42%> (-5.38%) ⬇️
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 98.85% <0.00%> (-0.56%) ⬇️
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.58% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc38ac6...108a5f0. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit c37dd80 into master Sep 1, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/issue/273 branch September 1, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alarm (Time based)
1 participant