Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the process of applying equalization in CONTRIBUTING.md #419

Closed
Lesik opened this issue Nov 25, 2020 · 5 comments
Closed

Document the process of applying equalization in CONTRIBUTING.md #419

Lesik opened this issue Nov 25, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Lesik
Copy link

Lesik commented Nov 25, 2020

Is your feature request related to a problem? Please describe.

Some (21 of 35 as of 2020-11) sounds in this repo are equalized (#313). When adding or modifying sounds, equalization should be applied to them. This process should be documented in CONTRIBUTING.md.

Describe the solution you'd like

A step-by-step guide on how to equalize sounds, that is easily understood even by contributors who are not familiar with Audacity.

Additional context

This comment describes the process somewhat, but is not easy to understand: #227 (comment)

@Lesik Lesik added the enhancement New feature or request label Nov 25, 2020
@Lesik
Copy link
Author

Lesik commented Nov 25, 2020

As of 2020-11, @ashutoshgngwr noted that not all sounds produce acceptable results when equalized. The following command might be of help, which, when run in the root of the repo, prints the file paths of all the sounds that @ashutoshgngwr deemed equalizable (in #313) and writes them to a file. Audacity can then be instructed to open the files as separate tracks in one window, instead of one window per file.

$ git diff-tree 2ce730c08992b50c27923a752dd2e36b89499574 --name-only --no-commit-id -r | awk -v pwd="$PWD" '{print "file \""pwd"/"$1"\""}' > audacity.lof
$ audacity audacity.lof

@ashutoshgngwr ashutoshgngwr self-assigned this Nov 25, 2020
@Lesik
Copy link
Author

Lesik commented Nov 25, 2020

@GittyBruce According to my understanding, loudness normalization level is related to the input sounds it is applied on. If you apply it on two files of which one is very loud and the other very quiet, it will normalize both to a middle level. If it is applied on two loud or quiet files, they will (mostly) retain their loudness because on a relative scale, there is (almost) nothing to normalize. Therefore, all (eligible) sounds in the library must be fed to the equalizer at once, so that they all match each other. Am I wrong?

@ashutoshgngwr
Copy link
Member

@Lesik - @GittyBruce implied applying the compressor effect. AFAIK, it tries to minimise the gap between the highest and lowest amplitude of the sound wave. The following excerpt is from Wikipedia:

an audio signal processing operation that reduces the volume of loud sounds or amplifies quiet sounds, thus reducing or compressing an audio signal's dynamic range.

From what I've observed, the end result is a bit more smooth on the ear. IMO, it's not necessary to apply the effect on each and every sample. It can be applied if the end result sounds better than the source.

As of 2020-11, @ashutoshgngwr noted that not all sounds produce acceptable results when equalized.

This happened because I applied a macro to all the sounds to avoid manually opening and applying the effect. As a result of this batch processing, some perfectly looping sounds ended up having weird silence (not complete silence but a slight reduction in volume) at their edges. Having limited time at hand, I omitted them from the commit at the time.

As for the settings, you can either play with them to find the sweet spot or use the settings suggested by @GittyBruce in the original comment. As far as I remember, the suggested settings produced a very decent output compared to the other settings that I tried at the time.

@ashutoshgngwr
Copy link
Member

Hey @Lesik

I went ahead and made all the changes. I've also reverted the 3 beep sample to the old 2 beep sample. 654a2c9

@Lesik
Copy link
Author

Lesik commented Nov 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants