New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidying up the 'strings.xml' files #442
Comments
@berkaygunduzz While this sounds awesome, you'll have to do it for all the locales to keep things consistent. I'm open to accepting these changes if you're upto it. |
Great, i will start it as soon as possible. |
@ashutoshgngwr How it looks like? This is a draft and it will be alphabetical. If you have suggestions i'm open to them. Btw, i won't make it hand by hand, i will make a Python script that will do it. Also i will share it when finished. |
@berkaygunduzz Yeah, this works! Much better than the what we have now. |
I don't have a full perfection on app so when you have time, can you control that all strings are in correct topic? |
I made a few changes and added more granular sections. I accidentally replaced 3-blank lines with 2-blank lines. You can keep whichever you prefer. |
Looks great, thanks. |
@ashutoshgngwr Because of i used Python script , it converted special chars to codes like |
Ok, i will try to fix it. |
@berkaygunduzz Ignore that comment. As you said, it was the script that did this. Let me see if I can find a fix. |
Could you please share your script so that I know what I am dealing with? |
It's a bit messy. Tested and worked with Python 3.8.6 |
Btw, I can fix it with this codes are decimal and it gives me unicode |
@berkaygunduzz On line 38, if you pass another parameter Ref: https://stackoverflow.com/questions/10046755/write-xml-utf-8-file-with-utf-8-data-with-elementtree |
Well, that's great. Thanks |
Do you want me to delete topic comments if it has no strings? |
Yeah, you can delete the empty ones. |
Tidying up the 'strings.xml' files for #442
Is your feature request related to a problem? Please describe.
When i translate, it was hard to find out where am i and where is the string that i will control.
Describe the solution you'd like
I want to group strings and make topic comments to their head for all string.xml files.
Group names that i suggest:
An example:
The text was updated successfully, but these errors were encountered: