Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes brownian noise sound #325

Merged
merged 1 commit into from Sep 10, 2020
Merged

Fixes brownian noise sound #325

merged 1 commit into from Sep 10, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #325 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   86.71%   86.74%   +0.02%     
==========================================
  Files          30       30              
  Lines        1596     1599       +3     
  Branches      178      178              
==========================================
+ Hits         1384     1387       +3     
  Misses        114      114              
  Partials       98       98              
Flag Coverage Δ
#android 86.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.58% <100.00%> (+<0.01%) ⬆️
cast-receiver/src/library.mock.ts 100.00% <0.00%> (ø)
cast-receiver/src/status_ui_handler.ts 97.43% <0.00%> (ø)
cast-receiver/src/player_manager.ts 94.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90b01f...a5f952f. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit d3d6bdb into master Sep 10, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/brownian-noise branch September 10, 2020 09:50
@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant