-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request]: Integrate Custom Error Pages #38
Comments
Hi @ashutoshkrris! I have some knowledge of Flask. May I be assigned this issue? I'll do my best! |
Yeah, you can work. For the time being, what you can do is return any custom error page. Later when the issue #37 is resolved, we can change it. |
Thank you @ashutoshkrris! If I get stuck, is dropping a comment here the best way to reach you? Do you have a discord for this repo by chance? |
You can drop your queries here, or if you wish you can create a discussion |
I believe I'm done! Thank you for the helpful reference link, Ashutosh! Commit is here. I'll wait for @rachelcynthia to make a pull request. |
@taanguyen I have made a pull request. I linked the pages to custom error routes for the time being. That will have to be deleted later and replaced with routes you designed. |
@taanguyen I have merged the PR made by @rachelcynthia |
thank you both! |
@ashutoshkrris, I tried to recreate the 405 error, but when I send a POST to localhost:5000/ (instead of a GET), I get a 302 and then a GET / request is made which returns a 200. Is that the expected behavior? |
Remove the trailing slash at the end of the URL and try. |
I see the change as index now accepts GET and POST- thank you! |
Is there an existing issue for this?
Describe the feature.
Our application should be able to serve custom error pages whenever it encounters an error.
Problem/Motivation.
Currently, whenever a user encounters an error, the default error pages are shown to the user, which is boring.
Possible Solution/Pitch.
Create view functions in the
routes.py
file to handle errors and serve custom error page templates.You can take reference from here
Anything else?
This is a backend-related issue, and any beginner who has little knowledge of Flask can also resolve it.
Hacktoberfest
Code of Conduct
The text was updated successfully, but these errors were encountered: