-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ compatibility errors with stringzilla.h #84
Comments
Thanks for suggestions, @WillisMedwell! Both sound reasonable! Can you please open a PR into |
It's a bit difficult to debug when there are no example projects to validate the changes, would you consider adding an examples folder with different language projects? Due to the many supported languages, it seems difficult at the moment to validate each one. You could then run an action to validate each of them, and it also provides users with examples of how to integrate with their python, c++, and other projects. I would be happy to do this for C++ if its something that aligns with your vision of the repo? |
Not sure what you mean, @WillisMedwell. Have you checked the CONTRIBUTING.md and the scripts folder? In VSCode you will also get tasks and launchers preconfigured once you open the project. |
@ashvardanian my bad i didnt realise the testing suite was under ./scripts. But my point being that you could have an ./example folder with different ways of installing the lib for c++, python ect. Then you could validate, demonstrate & scope the intended way of using the lib. I only suggest this as 'zilla supports many different languages and it might be difficult to know when stuff breaks. |
@WillisMedwell, there is a CI pipeline on GitHub. We don't merge until the tests for all languages pass and environments pass. Regarding a separate folder for examples, I try to avoid branching the directory tree too much. Cause then I'll have to make separate folders for unit tests, fuzzy tests, stress tests, benchmarks... across all languages. Hope this makes sense 🤗 |
Using clang-cl this error is generated when including stringzilla.hpp.
To resolve this issue, I think you can wrap the include in file: stringzilla.hpp line 62:
From
To
But I'm not 100%, probably worth some investigating.
In addition, fetch content section probably isn't verbose enough (especially considering the joy of working with cmake)
The text was updated successfully, but these errors were encountered: