-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification from the notification API #72
Comments
I took a quick look at the code, and it looks like any pluggable SCM material should be able to use the post commit hook (but in a specific way). The endpoint should be:
The param expected is
Can you see if that works? I don't think that will allow you to directly connect a GitHub webhook to GoCD, because of the expectation of the header (Confirm) and the data parameter (scm_name), but it might be a start towards what @mrmanc mentioned in gocd/gocd#217 (comment). |
Thanks @ashwanthkumar, @arvindsv. Cool, so I understand from that that if we find a way to transform GitHub webhooks into GoCD notifications, then we can use this plugin without generating any more polling activity. Awesome :) I think that wraps up this issue… further discussion can happen in gocd/gocd#217 (comment). |
gocd/gocd#217 is closed and we use What do we need to to do to have PR builds working with github webhooks only and without polling? (Polling is limited by our Github Enterprise team) |
gocd/gocd#8170 finished a few days ago and to be released in 20.9.0 might be relevant. |
Hello
I was wondering whether this plugin hooks in to the Go Notification API (https://api.go.cd/current/#notify-git-materials) to accept published Git events? Or does it always have to poll the GitHub server to work out when a new commit / pull request has happened?
Thanks
The text was updated successfully, but these errors were encountered: