Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential inter-mod conflict with Botania #1

Closed
3TUSK opened this issue Nov 24, 2016 · 6 comments
Closed

Potential inter-mod conflict with Botania #1

3TUSK opened this issue Nov 24, 2016 · 6 comments
Assignees
Labels

Comments

@3TUSK
Copy link

3TUSK commented Nov 24, 2016

First of all, thanks alot for making FoamFix!
The issue I ran into is that, after installing FoamFix into Skyexchange 1.2.3, all of my floating flowers from Botania have weird model, which, I swear, that has never seen before until today I install FoamFix (last time I opened this pack was weeks ago), as shown by following screenshots:

A munchdew:
2016-11-24_10 37 12
A hopperhock:
2016-11-24_10 37 27
Another hopperhock:
2016-11-24_10 37 39
Yet another hopperhock:
2016-11-24_10 38 29

The version of botania I am using is r1.9-333. MinecraftForge version is 12.18.2.2121.
@TartaricAcid can replicate the same issue within Botania r1-.9-339, which is the latest version of Botania.

Since I am not sure abuot the cause of this issue, I figure that I need also ping @Vazkii

@asiekierka asiekierka self-assigned this Nov 24, 2016
@asiekierka
Copy link
Owner

Main question: Does it happen with just Botania installed? If yes, the simple solution is to blacklist Botania's flower models from being handled by the deduplicator until a suitable solution is found - I should be able to add a config option for this into 0.3.2.

@3TUSK
Copy link
Author

3TUSK commented Nov 24, 2016

Confirmed that the same issue happens with just Botania r1.9-239 (incl. Baubles and AutoRegLib as required library) and FoamFix. MinecraftForge version is 12.18.2.2151 which is the latest.
2016-11-24_13 39 36

@asiekierka
Copy link
Owner

Fixed in 0.3.2.

@asiekierka
Copy link
Owner

asiekierka commented Jan 21, 2018

No. That was incorrect. Worked around in 0.3.2.

We're getting this fixed. One day.

@asiekierka asiekierka reopened this Jan 21, 2018
@3TUSK
Copy link
Author

3TUSK commented Jan 21, 2018

Surprise! A wild issue revived

@asiekierka
Copy link
Owner

0.9.x series brings back the optimization. Closed and fixed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants