Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better management of query type #349

Closed
mboudet opened this issue Jun 24, 2022 · 0 comments · Fixed by #385
Closed

Better management of query type #349

mboudet opened this issue Jun 24, 2022 · 0 comments · Fixed by #385

Comments

@mboudet
Copy link
Contributor

mboudet commented Jun 24, 2022

Since we now send queries on the protected endpoint, we should explicitly specify the query type.

Auto-detection fails in some case, because the lib detect the 'ASK' of askomic...

Basically SPARQLWrapper autodetect the query type based on content (ie: DELETE, ASK, etc..), and send 'modifying' queries on the protected endpoint.

Except that if we use prefixes in the query, the lib will always detect the type as 'ASK', and send it to the unprotected endpoint.

This 'works' most of the time, but fails when publishing a dataset.

Since we know direct queries (through the ASK interface, or the sparql query) can only be SELECT queries, we should not rely on autodetection, and directly force the query type. It will increase security, since for now users can delete graphs through the SPARQL console.

@mboudet mboudet mentioned this issue Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant