Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Overlap with" missing some cases #406

Closed
mboudet opened this issue Jul 19, 2023 · 0 comments · Fixed by #404
Closed

"Overlap with" missing some cases #406

mboudet opened this issue Jul 19, 2023 · 0 comments · Fixed by #404

Comments

@mboudet
Copy link
Contributor

mboudet commented Jul 19, 2023

For now, A 'overlap with' B means the following:

(B.start > A.start && B.start < A.end) || (B.end > A.start && B.end < A.end)

This misses the case where A is included in B.

A.start > B.start && A.end < B.end
@mboudet mboudet mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 403 mboudet/flaskomics
1 participant
@mboudet