-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add better sources for used libs #302
Comments
I used v0.8.0.0 for AndroidCommon and the latest locale library extracted from the zip on their website. It has android-17 in project.properties yet I still get errors: package com.twofortyfouram.locale.platform.R does not exist. |
I assume you have included locale as a lib to the BBS. This error point to the lib not compiling properly ans so the resource constant file not getting generated. But please contact me directly if you have questions on how to build BBS, this is not related with this feature request. |
OK, I'll post in XDA |
I'm stiill getting this error: tried with openjdk 1.6 and 1.7. It seems to be extremely easy to patch Locale library out by just removing src/com/asksven/betterbatterystats/localeplugin and a chunk of the Manifest. That is a non-free app anyway which wouldn't be of much interest to our users so we'll go ahead with this patch (when we get time) Could you mention in th README what the overall license is? Just because the souce code headers are Apache the resources may not be. |
I don't see the need to remove anything as BBS builds (I have updated the ant script so if your project is set up properly, including all dependencies there are no reason for the build to fail). |
There is no custom_rules.xml and the build.xml is standard, so I'm don't know what ant scripts you are referring to. The Readme mentions licenses for libraries and there are notices in libs, but nowhere does it actually say BBS , as a whole, is Apache licensed. Like I said, certain resources could be under a proprietary licence and it could be illegal in that case to distribute the apk under the Apache licence |
by dalb8: Thanks for putting the jar licenses in the libs/, but could you write where you got them too and also the commits used for the sub projects? I would like to include this in F-Droid.org repo for the benefit of all freedom loving Android users. Obviously we would remove Analytics because it isn't free. Donation links are welcome.
The text was updated successfully, but these errors were encountered: