Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are you asking for so many permissions on GitHub? #3

Closed
StevenTCramer opened this issue Aug 31, 2023 · 6 comments
Closed

Why are you asking for so many permissions on GitHub? #3

StevenTCramer opened this issue Aug 31, 2023 · 6 comments

Comments

@StevenTCramer
Copy link

image

@dsomok
Copy link
Contributor

dsomok commented Sep 3, 2023

Hello @StevenTCramer,

Thank you for raising an issue. I acknowledge that requiring admin permission for "Repository webhooks and services" is an oversight on my part. I apologize for the inconvenience and will address this in the next release.

As for requesting access to private repositories, it is an intended behavior. This allows users to communicate with the code in their private repositories using the AskTheCode plugin. I want to assure you that AskTheCode does not collect or store the contents of the files, neither in any storage nor in logs. The AskTheCode plugin acts purely as a proxy to download the content and send it to ChatGPT for processing.

I apologize for the delay in my response. I wanted the Issues feature to be implemented enough to be able to reply.

Note: This reply was generated and posted by the Github Issues feature of the AskTheCode plugin. This feature is currently in development and will be released soon.

@Zure1
Copy link

Zure1 commented Sep 4, 2023

A lot of those permissions seem to be unnecessary. Anything else than 'Code' should not be interesting for the plugin. In addition, why does it need write permissions?

Bildschirmfoto 2023-09-04 um 09 55 11

@dcaud
Copy link

dcaud commented Sep 4, 2023

I think including issues is okay -- there could be relevant info in issues. But not:

Deploy keys or Collaboration invites.

Also, granting write access seems unnecessarily dangerous. I'd like to remove that too.

@Zure1
Copy link

Zure1 commented Sep 4, 2023

As far as I understand, it only downloads the code and sends it to ChatGPT, so reading issues seems pointless as of now.

@dsomok
Copy link
Contributor

dsomok commented Sep 4, 2023

Hello everyone,

Thank you for your feedback and concerns regarding the permissions requested by the AskTheCode plugin. The primary goal is to allow users to query both public and private repositories.

Currently, the OAuth app (not the GitHub App) is used to authenticate users. Due to GitHub's current OAuth permission model, to access private repositories, I need to request the repo scope. This scope, unfortunately, grants full control of private repositories, which includes both read and write access. As of now, GitHub does not provide a separate read-only scope for private repositories. This means that even though the intention is only to read from your repositories, the permission model makes it appear as if the plugin is requesting broader access.

For more details on GitHub OAuth scopes, you can refer to the official documentation.

@Zure1
Copy link

Zure1 commented Sep 4, 2023

That's a quite sad limitation. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants