Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of requests which support session, curl generator, unit test... #26

Closed
wants to merge 45 commits into from

Conversation

ahuigo
Copy link

@ahuigo ahuigo commented Jan 26, 2022

I refactored all code to support more features and make it easy to use.

@asmcos
Copy link
Owner

asmcos commented Jan 28, 2022

我很乐意接受你对requests的修改。但是你把库的引用地址,甚至连我的名字 都改成你的,我没有办法接受这个 pr.
谢谢。

@ahuigo
Copy link
Author

ahuigo commented Jan 28, 2022

谢谢。

抱歉,忘记这事了,解释一下。

我原来是想作为一个衍生项目维护的,因为api不会兼容+我要马上使用——所以就把项目地址指向我的仓库,版权说明中你的名字仍然是保留的。

现在想将代码合并到你这里——我应该把库的引用地址改回你的,不过这份代码与原来不兼容,可能要发一个大版本。

@ahuigo
Copy link
Author

ahuigo commented Jan 28, 2022

刚把仓库的地址一键替换回你的名字了,这个pull 我就关闭了

@ahuigo ahuigo closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants