Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Redis connection creation #100

Merged
merged 1 commit into from Jan 16, 2013
Merged

Simplified Redis connection creation #100

merged 1 commit into from Jan 16, 2013

Conversation

tobiashm
Copy link
Contributor

Redis-rb has a built in URL parser, which also handles specifying db # etc.

Redis-rb has a built in URL parser, which also handles specifying db # etc.
@lucasefe
Copy link

lucasefe commented Oct 3, 2012

+1

(I removed the explanation because the reason is already on the commit message)

@inkel
Copy link

inkel commented Oct 3, 2012

I'd really like to see this merged, though it'd probably be better to supply a Redis.new instance directly, so I can use a socket to connect to Redis if I wanted to.

@tobiashm
Copy link
Contributor Author

tobiashm commented Oct 4, 2012

@inkel you can use a unix socket with Redis given a URL like unix:///path/to/socket

@inkel
Copy link

inkel commented Oct 4, 2012

Thanks @tobiashm, but what about if I want to indicate a differente Redis database number? Or to have authentication?

In fact, I would allow passing whatever arguments I like to Redis.new, but maybe it's just me :)

@tobiashm
Copy link
Contributor Author

tobiashm commented Oct 5, 2012

I think an alternative option to pass in a Redis instance would also be nice. But the purpose of this pull request is simply to improve the handling of redis_url.

asmuth added a commit that referenced this pull request Jan 16, 2013
Simplified Redis connection creation
@asmuth asmuth merged commit b75665f into asmuth:master Jan 16, 2013
@tobiashm tobiashm deleted the patch-1 branch October 28, 2014 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants