Simplified Redis connection creation #100

Merged
merged 1 commit into from Jan 16, 2013

Conversation

Projects
None yet
4 participants
Contributor

tobiashm commented Sep 27, 2012

Redis-rb has a built in URL parser, which also handles specifying db # etc.

Simplified Redis connection creation
Redis-rb has a built in URL parser, which also handles specifying db # etc.

lucasefe commented Oct 3, 2012

+1

(I removed the explanation because the reason is already on the commit message)

inkel commented Oct 3, 2012

I'd really like to see this merged, though it'd probably be better to supply a Redis.new instance directly, so I can use a socket to connect to Redis if I wanted to.

Contributor

tobiashm commented Oct 4, 2012

@inkel you can use a unix socket with Redis given a URL like unix:///path/to/socket

inkel commented Oct 4, 2012

Thanks @tobiashm, but what about if I want to indicate a differente Redis database number? Or to have authentication?

In fact, I would allow passing whatever arguments I like to Redis.new, but maybe it's just me :)

Contributor

tobiashm commented Oct 5, 2012

I think an alternative option to pass in a Redis instance would also be nice. But the purpose of this pull request is simply to improve the handling of redis_url.

asmuth added a commit that referenced this pull request Jan 16, 2013

Merge pull request #100 from tobiashm/patch-1
Simplified Redis connection creation

@asmuth asmuth merged commit b75665f into asmuth:master Jan 16, 2013

@tobiashm tobiashm deleted the tobiashm:patch-1 branch Oct 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment