Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(not priority)batch scraping data, unchecked media still being scanned and downloaded #25

Closed
ghost opened this issue Nov 16, 2016 · 4 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Nov 16, 2016

scrap function downloads everything even if some media was unchecked checked on settings, just wanted rom/game info and not extra media files but those are still being scanned for and downloaded

also add columns for game data like year,genre, developer or publisher if available.

@Asnivor
Copy link
Owner

Asnivor commented Nov 16, 2016

scrap function downloads everything even if some media was unchecked checked on settings, just wanted rom/game info and not extra media files but those are still being scanned for and downloaded

I'll look into that.

also add columns for game data like year,genre, developer or publisher if available.

Those fields are there in the sidebar and should only be shown if that specific data has been scraped (and is available on the site that you have scraped from):

image

Are you saying that you want these columns to also appear in the main games library list?

Thanks.

@Asnivor Asnivor added the bug label Nov 16, 2016
@Asnivor Asnivor self-assigned this Nov 16, 2016
@ghost
Copy link
Author

ghost commented Nov 16, 2016

i wanted them also in columns so i can sort games by like all irem games or konami releases.

@Asnivor
Copy link
Owner

Asnivor commented Nov 16, 2016

Ok cool. That is do-able with a bit of work. Currently once a game is scraped a .json file is generated in the data folder for that game.

If I were to pull in data from all these files as the datagrid is 'built' it would be fantastically slow. Its probably more sensible to have a few more fields in the Game database that get populated every time a game is scraped (and wiped out if the scraping link between game data and game database entry is removed).

Its definitely a good idea though (maybe with settings to show or hide these columns for users that dont want to see them). I'll create an 'enhancement' issue on GitHub for this and get to it when i get to it :)

Thanks.

@Asnivor
Copy link
Owner

Asnivor commented Nov 17, 2016

Media downloading bug fixed in commit (will be available in the next release) eaa800a

Enhancement request moved to new issue

@Asnivor Asnivor closed this as completed Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant